Conversation
Add min_length=1 and max_length=128 constraints to the CardQuery.number
field so that invalid card numbers are rejected with a 422 Unprocessable
Entity response instead of being passed through to the database and
returning a misleading 404.
Closes stayforge/Stayforge_Networks_Access#9
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_length=128,min_length=1, and alphanumeric pattern validation toCardQuery.numberfieldCardQuery.numberwas a plainstrwith no constraints, so invalid input (e.g., overly long strings or special characters) would pass validation and hit the database, returning 404 instead of the expected 422 validation errorCardModel.numberCloses stayforge/Stayforge_Networks_Access#9
Test plan
🤖 Generated with Claude Code